Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fan Control / Hwmon(#2329): Handle OCC temp sensor failure #2222

Closed
msbarth opened this issue Aug 29, 2017 · 3 comments
Closed

Fan Control / Hwmon(#2329): Handle OCC temp sensor failure #2222

msbarth opened this issue Aug 29, 2017 · 3 comments
Assignees
@spinler @msbarth

Comments

@msbarth
Copy link
Contributor

msbarth commented Aug 29, 2017

When a temp sensor that is provided by the OCC times out having read failures, a 0xFF value is returned in the current temp reading byte. When a 0xFF is read by fan control, the fans for zone 0 should be set to full speed (10500rpms)
occ_temp_format
@spinler spinler mentioned this issue Aug 30, 2017
Closed
@rfrandse rfrandse added this to the openBMC v2.0 Backlog milestone Aug 30, 2017
@anoo1 anoo1 added defer and removed Phase 5.1 labels Sep 21, 2017
@anoo1 anoo1 modified the milestones: openBMC v2.0 Backlog, openBMC v3.0 Backlog Sep 21, 2017
@zahrens zahrens modified the milestones: openBMC v3.0 Backlog, openBMC v2.2 Backlog, OpenBMC v2.1 Backlog Nov 10, 2017
@zahrens zahrens added Phase 9 and removed defer labels Nov 16, 2017
@zahrens zahrens removed this from the IBM Milestone 2 milestone Nov 29, 2017
@zahrens zahrens removed the Phase 9 label Nov 29, 2017
@amboar
Copy link
Member

amboar commented Mar 14, 2018

Are we exposing these values via the sensor value attribute? I feel like this case should be translated into -EAGAIN or -EIO on reading the attribute.

@msbarth
Copy link
Contributor Author

msbarth commented Mar 14, 2018

Pre-4.13 these 0x00 & 0xFF values were being presented in the sensor value attribute. A driver update was made (and included in post-4.13) to provied EAGAIN for 0x00 and EIO on 0xFF, however the user side support in hwmon was not complete, hence this issue. This problem is in discussion right now and scheduling the work is underway.

@msbarth msbarth changed the title Fan Control / Hwmon: Handle OCC temp sensor failure Fan Control / Hwmon(#2329): Handle OCC temp sensor failure Mar 20, 2018
@rfrandse
Copy link

https://gerrit.openbmc-project.xyz/10334 wspoon: Handle faulted OCC temp sensors
Resolves: #2222 Fan Control / Hwmon(#2329): Handle OCC temp sensor failure

geissonator pushed a commit to openbmc/meta-openpower that referenced this issue Aug 6, 2018
@msbarth @bradbishop
wspoon: Handle faulted OCC temp sensors
501d1a3 
When a temp sensor provided by the OCC is faulted, set the fans to full
speed(10500 RPMs)

Tested:
    Set Functional property of an OCC provided sensor to `true` and
    fans are set to 10500.
    Fan speeds drop when the same Functional property is set to `false`

Resolves: openbmc/openbmc#2222

Change-Id: Iddd9049fc9677ca587422a5bf4104c0d3787af1a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-ibm that referenced this issue Aug 22, 2018
@msbarth @bradbishop
wspoon: Handle faulted OCC temp sensors
7b7aa13 
When a temp sensor provided by the OCC is faulted, set the fans to full
speed(10500 RPMs)

Tested:
    Set Functional property of an OCC provided sensor to `true` and
    fans are set to 10500.
    Fan speeds drop when the same Functional property is set to `false`

Resolves: openbmc/openbmc#2222

Change-Id: Iddd9049fc9677ca587422a5bf4104c0d3787af1a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spinler spinler

@msbarth msbarth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@amboar @anoo1 @spinler @msbarth @rfrandse @zahrens