Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network:- Defer the systemd-networkd restart #2227

Closed
ratagupt opened this issue Aug 30, 2017 · 4 comments
Closed

Network:- Defer the systemd-networkd restart #2227

ratagupt opened this issue Aug 30, 2017 · 4 comments
Assignees

Comments

@ratagupt
Copy link
Contributor

It is agreed on that instead of starting the systemd-networkd for each network operation,we would defer it for some time.
There are two approaches

  1. we would wait for a certain amount of time and cache all the changes and then restart the systemd-networkd.
  2. one more dbus method say "apply Changes".which will apply all the changes and restart the systemd-networkd.
    Need to look at the pros and cons of both approaches.
@ratagupt
Copy link
Contributor Author

ratagupt commented Sep 4, 2017

It is not a code review defect,It is enhancement.

@ratagupt
Copy link
Contributor Author

ratagupt commented Sep 7, 2017

As discussed we will go with the approach 1

  • Implement the timer which is already there.

  • Start the timer whenever we get any dbus request,Need to make sure that only start the timer if it is not started.

  • Once timer expired then restart the systemd-networkd.

@rfrandse
Copy link

https://gerrit.openbmc-project.xyz/6844 Reducing the restart of systemd-networkd by implementing timers
Resolves #2227 Network:- Defer the systemd-networkd restart

@sivassrr
Copy link

Not seeing much impact to existing network TCs. We need to rerun and do regression test. @prkatti1 FYI .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants