Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipv6 link local addresses should not implement Delete. #2342

Closed
bradbishop opened this issue Sep 20, 2017 · 7 comments
Closed

ipv6 link local addresses should not implement Delete. #2342

bradbishop opened this issue Sep 20, 2017 · 7 comments
Labels
bug stale

Comments

@bradbishop
Copy link
Member

Any attempt to do this is just going to raise an error so the option should not be given in the first place.

@ratagupt @dkodihal ^
@bradbishop bradbishop added this to the openBMC v2.1 Backlog milestone Sep 20, 2017
@ratagupt
Copy link
Contributor

I think we can implement delete but during delete we should put a check if it is linklocal/zeroconfig then it can not be deleted..

@ratagupt
Copy link
Contributor

Currently if user says delete then it is a no-op for user..as we would restart the network which will again create it.But we can optimisie it as don't allow to delete it.

@zahrens zahrens removed the Phase 7 label Nov 10, 2017
@rfrandse rfrandse mentioned this issue Dec 3, 2018
Closed
@stale
Copy link

stale bot commented Mar 28, 2019

This issue has been automatically marked as stale because no activity has occurred in the last 6 months. It will be closed if no activity occurs in the next 30 days. If this issue should not be closed please add a comment. Thank you for your understanding and contributions.

@stale stale bot added the stale label Mar 28, 2019
@rfrandse rfrandse removed this from the IBM Backlog 1 milestone Mar 28, 2019
@stale stale bot removed the stale label Mar 28, 2019
@rfrandse rfrandse removed this from the IBM Backlog 1 milestone Mar 28, 2019
@stale
Copy link

stale bot commented Sep 27, 2019

This issue has been automatically marked as stale because no activity has occurred in the last 6 months. It will be closed if no activity occurs in the next 30 days. If this issue should not be closed please add a comment. Thank you for your understanding and contributions.

@stale stale bot added the stale label Sep 27, 2019
@bradbishop
Copy link
Member Author

I still think we should have better behavior here, if we haven't addressed this. @ratagupt or @wak-google any idea what the current behavior is?

@stale stale bot removed the stale label Sep 30, 2019
@stale
Copy link

stale bot commented Mar 31, 2020

This issue has been automatically marked as stale because no activity has occurred in the last 6 months. It will be closed if no activity occurs in the next 30 days. If this issue should not be closed please add a comment. Thank you for your understanding and contributions.

@stale stale bot added the stale label Mar 31, 2020
@stale
Copy link

stale bot commented Apr 30, 2020

This issue has been closed because no activity has occurred in the last 7 months. Please reopen if this issue should not have been closed. Thank you for your contributions.

@stale stale bot closed this as completed Apr 30, 2020
@cmjishnu cmjishnu mentioned this issue Mar 29, 2023
Merged
rfrandse pushed a commit to ibm-openbmc/phosphor-networkd that referenced this issue Apr 3, 2023
@cmjishnu @cm-jishnu
Update the error on deleting a link local address (#70)
173ba5a 
It is in reference to openbmc/openbmc#2342

Currently, when a user tries to delete a non-static ip address, it throws an error as "the operation failed internally"

With the update, when an attempt is made to delete the link-local address of the bmc it throws "The operation is not allowed" error

Tested by:

Current behaviour:

busctl call xyz.openbmc_project.Network /xyz/openbmc_project/network/eth1/_66e80_3a_3aa94_3aefff_3afe81_3ad629_2f64 xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation failed internally.

Modified behaviour:

busctl call xyz.openbmc_project.Network /xyz/openbmc_project/network/eth1/_66e80_3a_3aa94_3aefff_3afe81_3ad62d_2f64 xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation is not allowed

Change-Id: Ib5df33b8ad356a868aecc508ad6531ed15390a1d

Signed-off-by: Jishnu CM <jishnunambiarcm@duck.com>
Co-authored-by: Jishnu CM <jishnunambiarcm@duck.com>
@cmjishnu cmjishnu mentioned this issue Jun 8, 2023
Merged
rfrandse pushed a commit to ibm-openbmc/phosphor-networkd that referenced this issue Jun 12, 2023
@cmjishnu @cm-jishnu
Update the error on deleting a link local address (#91)
002ef77 
It is in reference to openbmc/openbmc#2342

Currently, when a user tries to delete a non-static ip address,
it throws an error as "the operation failed internally"

With the update, when an attempt is made to delete the link-local
address of the bmc it throws "The operation is not allowed" error

Tested by:

Current behaviour:

busctl call xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1/_66e80_3a_3aa94...
xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation failed internally.

Modified behaviour:

busctl call xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1/_66e80_3a_3aa94...
xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation is not allowed

Change-Id: Ib5df33b8ad356a868aecc508ad6531ed15390a1d

Signed-off-by: Jishnu CM <jishnunambiarcm@duck.com>
Co-authored-by: Jishnu CM <jishnunambiarcm@duck.com>
geissonator pushed a commit to openbmc/phosphor-networkd that referenced this issue Jul 21, 2023
@cm-jishnu @wak-google
Update the error on deleting a link local address
7af5b73 
It is in reference to openbmc/openbmc#2342

Currently, when a user tries to delete a non-static ip address,
it throws an error as "the operation failed internally"

With the update, when an attempt is made to delete the link-local
address of the bmc it throws "The operation is not allowed" error

Tested by:

Current behaviour:

busctl call xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1/_66e80_3a_3aa94...
xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation failed internally.

Modified behaviour:

busctl call xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1/_66e80_3a_3aa94...
xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation is not allowed

Change-Id: Ib5df33b8ad356a868aecc508ad6531ed15390a1d
Signed-off-by: Jishnu CM <jishnunambiarcm@duck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bradbishop @ratagupt @rfrandse @zahrens