testing Jenkins integration, please ignore #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing Jenkins |
|
Can one of the admins verify this patch? |
|
test this please |
|
@jenkins-openbmc test this please |
|
test this please |
1 similar comment
|
test this please |
|
Can one of the admins verify this patch? |
|
add to whitelist |
|
retest this please |
1 similar comment
|
retest this please |
|
I think we're done with this test PR now. Sorry for the noise. |
anoo1
pushed a commit
to anoo1/openbmc
that referenced
this pull request
Jul 28, 2020
meta-ibm: Fix issue: fanx_1 can't get the correct pwm
stefanberger
pushed a commit
to stefanberger/openbmc
that referenced
this pull request
Aug 1, 2023
Sandeepa Singh (47): Firmware-change (openbmc#66) Allow only tar file upload (openbmc#71) Hardware Deconfiguration Page (openbmc#84) Deconfig-Toggles (openbmc#110) Filter SNMP data (openbmc#112) Upload acf certificate on login page (openbmc#126) Hardware deconfiguration fix (openbmc#128) TFTP firmware update (openbmc#104) Add filter to remove absent dimms form GUI (openbmc#139) Add abiliy to sort hardware deconfig columns (openbmc#162) Add helptext for FQDN (openbmc#164) Add deconfiguration type as None (openbmc#163) Fix link to deconfiguration records (openbmc#155) Remove regex from firmware (openbmc#151) Add alert for HMC connection disconnect (openbmc#152) Update hardware deconfiguration per Demo feedback (openbmc#180) Remove Default option from Server power operations page (openbmc#188) reverting removal of Default partition environment dropdown (openbmc#190) Add Lateral cast out page (openbmc#177) fix toggle issue (openbmc#191) Add details on login page (openbmc#193) Remove TFTP server option from firmware page (openbmc#194) Real time post codes converted to ASCII (openbmc#207) fix TFTP bug (openbmc#213) Show/Hide ACF upload button (openbmc#214) Fix toggle issue (openbmc#219) Change the toggle text to configure/deconfigure (openbmc#223) Fix the sorting issue in progress logs (openbmc#240) Translate severity to fatal,predictive and manual (openbmc#235) Add Pel ID column on HW deconfiguration page (openbmc#244) Show FW_boot_side_current attribute value (openbmc#262) Added filter to remove 00000000 from post code table (openbmc#272) Fix toast msg for HW deconfiguration page (openbmc#251) Add location code of Deconfig records page (openbmc#293) Make memory page consistent (openbmc#308) Add pel id column (openbmc#332) Update service login condition (openbmc#326) Edit app nav and login file (openbmc#335) Update Automatic helptext (openbmc#340) Grey out toggle when DHCP is disabled (openbmc#338) Disable delete when system is powered on (openbmc#327) Renamed added optimization page (openbmc#346) Fix deconfiguration record translation bug (openbmc#360) Fix power page translation bug (openbmc#361) Operating mode is translatable now (openbmc#363) Fix user management page translation bugs (openbmc#365) Fix server power ops translation bugs (openbmc#359) Kenneth Fullbright (85): Removed irrelevant fields from the VET Capabilities table (openbmc#68) Update Firmware page interactions when system is powered on (openbmc#51) Updated CSR Modal & Service login Certificate Modal (openbmc#59) Removed OemIBMServiceAgent from Group Privilege list (openbmc#76) Updated Power saver modes descriptions (openbmc#83) Popup SOL Console (Host Console) not showing correct connection status (openbmc#79) Removed irrelevant fields from the VET Capabilities table (openbmc#93) Added Initiate Resource Dump Function (openbmc#103) Fixed password change/reset code for expired password (openbmc#125) Fixed global action vuex error getUsers (openbmc#120) Fixed 'Promise.all' related errors on Overview (openbmc#119) Renamed "Serial over LAN (SOL) console" page (openbmc#54) Fixed event log table to be fully responsive (openbmc#122) Prevent service user password change (openbmc#88) Turned dumps PHYP alert into a toast (openbmc#140) Repaired Service login consoles links in the navbar (openbmc#145) Removed LDAP from navigation on non admin role accounts (openbmc#108) Updated the link to consoles and other nav related items Refactored Power page and power page related things (openbmc#109) Added Power restore policy missing alert on operating mode manual (openbmc#147) Made non-service roles not pass default password for resource dumps (openbmc#135) Fixed BMC Hypervisor console switch (openbmc#159) Enhanced user creation and current user failed message for password change (openbmc#81) Fixed translation double key error (openbmc#146) Removed service privilege option from edit user and add user (openbmc#161) Enhanced resource dump error messages (openbmc#168) Refactored Power page code for efficiency and clarity (openbmc#158) Fixed init system dump from resource dump (openbmc#136) Added toast for invalid privilege (openbmc#172) Fixed Service consoles (openbmc#176) Fix user management delete table action (openbmc#179) Fixed service account resource dumps password field to allow any string (openbmc#183) Fixed Idle power saving missing reset button option (openbmc#184) Removed lower and upper limit and warning sensors (openbmc#186) Fixed missing fields for add user on user modal (openbmc#185) Fixed maximum amount of users toast error (openbmc#196) Fixed delete and replace function in Certificates table (openbmc#197) Fixed navbar missing error (openbmc#206) Fixed popup BMC and Hypervisor consoles. (openbmc#205) Fixed init system dump PHYP in standby check error (openbmc#204) Fixed closing console conntections. (openbmc#220) Fixed upload certificate button not being disabled on max certificates (openbmc#224) Added info tool tips on password changing fields. (openbmc#225) Removed operator role from add role group modal (openbmc#229) [SW550540] Removed Operator and NoAccess roles from desciption table (openbmc#228) [SW550558] Fixed proxy logout error (openbmc#226) Created info icon for enhanced information about power consumption (openbmc#232) Fixed some tables not being fully responsive (openbmc#222) Set autocomplete option to off for password fields (openbmc#231) Added dump being offloaded warning for reboot and shutdown (openbmc#241) Fixed system dump error messages (openbmc#238) Fixed factory reset to default code (openbmc#243) Changed OemIBMServiceAgent to ServiceAgent (openbmc#261) Add safe mode to user interface (openbmc#250) Fixed fresh install set password and login error (openbmc#263) Fixed DHCP delete button not disabled (openbmc#273) Removed unsupported ServiceAgent group from LDAP group privilege modal (openbmc#268) Fixed Zombie state when factory resetting (openbmc#270) Fixed unauthorized error toast on page loading (openbmc#267) Fixed firmware swapping confusion (openbmc#271) Fixed console connection indicators (openbmc#275) Fixed account polocy settings displaying not updated info on refresh (openbmc#276) Fixed running and backup image info render problem (openbmc#287) Fixed event logs not updating upon delete all button (openbmc#290) Fixed account policy radio buttons (openbmc#289) Fixed secure LDAP checkbox not showing correct values (openbmc#291) Fixed firmware update function (openbmc#296) Fixed JSON.parse error from localStorage (openbmc#298) Fixed factory reset function to be fully async (openbmc#306) Removed host console access from ReadOnly roles (openbmc#307) Fixed SRC Details not showing on non manual records (openbmc#300) Fixed page memory validation error (openbmc#313) Fixed location code not showing on Deconfiguration records table (openbmc#317) Disabled users from changing username on user management table (openbmc#321) Added Location codes for TPM (openbmc#324) Fixed console indicators not updating status (openbmc#304) Added Location codes for TPM (openbmc#325) Made more meaningful toasts (openbmc#314) Fixed manage access keys hyperlink being disabled problems on Firmware page (openbmc#322) Fixed asset tag info not showing up in modal after app refresh and tag update (openbmc#333) Removed hashes from files (openbmc#334) Created real time indicator postCodeValue filter (openbmc#302) Fixed Deconfig table download additional data button (openbmc#328) Changed page "Lateral cast out" to "Added optimization" (openbmc#341) Added notices page (openbmc#336) A Nikhil (47): Update Inventory DIMM table (openbmc#74) Update Inventory Assemblies table (openbmc#87) Update Inventory Processors table (openbmc#86) Incorrect Power mode value (openbmc#89) Dumps available on BMC are not displayed on BMC-GUI (openbmc#72) Components on the hardware page not in order (openbmc#101) No values populated for licensed and configured cores (openbmc#91) Update GUI as IBM (openbmc#116) Rename Update Firmware access key (openbmc#117) Health and state field of assembly components is missing in inventory page (openbmc#99) Event logs add missing information (openbmc#111) GUI has no way to turn off System attention LED (openbmc#129) Event log does not show information for service (openbmc#133) GUI missing detailed COD (openbmc#124) Rename count in system table (openbmc#149) FCO page accepts value greater than the number of licensed cores (openbmc#142) Part number field is showing spare part number value (openbmc#165) Wrong lable on SRC for logs (openbmc#156) Inventory and LEDs page has two system entries (openbmc#137) Add toggle to enable/disable the secure version lock in (openbmc#167) Factory reset option should only be provided at power off (openbmc#174) Health in critical state after marking critical errors as resolved (openbmc#189) Concurrent maintenance Page (openbmc#202) Download implementation in Event logs (openbmc#192) Missing host USB enable/disable (openbmc#239) Prevent system power on when BMC is not in Ready state (openbmc#227) Adding mex chassis Info (openbmc#233) Mex IO enclosure firmware version not displayed (openbmc#265) PCIe Hardware Topology (openbmc#181) Warning in PcieTopology.vue (openbmc#282) Pcie-topology and Inventory fixes (openbmc#288) Unable to edit group name in the Add Role group field. (openbmc#303) PCIe Topology Save changes (openbmc#309) Invalid range for I/O Adapter enlarged capacity (openbmc#311) Status for both system and chassis comes as absent at host power off state (openbmc#312) Status for system table should be Present (openbmc#320) Fixed Identify LED error in MEX chassis (openbmc#330) Assemblies section does not has search option in Inventory page (openbmc#315) PCIe link width for empty slots is showing as -1 (openbmc#319) Warning message only in manual mode (openbmc#323) Fixed incorrect Identity LEDs error message (openbmc#331) Unwanted fields for MEX components removed (openbmc#329) PCIe topology performance improved (openbmc#337) AIX/LINUX and IBM i partition are only for non-HMC manage system (openbmc#318) Severity values is now translatable (openbmc#357) Enabled value taken from translation file (openbmc#362) Removed .tar.xz extension from dumps (openbmc#410) whitesource-ets[bot] (1): Add .whitesource configuration file sandeepasingh116 (17): Add new toggles on CM page (openbmc#3) Changed connection status logic for Hypervisor console (openbmc#6) Remove dump download option from overview page (openbmc#9) Add text on user management page (openbmc#8) Rename the save setting button (openbmc#20) Add success toast (openbmc#18) Fix network eth1 error (openbmc#21) Disable date and time page (openbmc#24) Update password helptext (openbmc#19) Add info tooltip to frequency cap (openbmc#25) Read only user will not be able to toggle switches (openbmc#28) Make filters translatable (openbmc#33) Fix translations of vet capabilities (openbmc#35) fix english texts containing links (openbmc#38) Remove service login label for read only user (openbmc#45) fix translation defect for server power ops (openbmc#52) add toogle on Policies page (openbmc#73) Reed Frandsen (1): Removed alert message from Update firmware component (openbmc#90) Gunnar Mills (3): Enable hmc proxy (openbmc#208) Update notices to 1030 (openbmc#50) Revert "Refresh only once after login (openbmc#42)" (openbmc#59) Nikhil Ashoka (33): pdated the text of server power ops documentation (openbmc#7) Displaying Sensors table one row at a time (openbmc#11) NTP server duplicate entry is not accepted (openbmc#4) Fabric Adapters Info in Inventory page (openbmc#12) Fixed Secure LDAP using SSL checkbox value (openbmc#2) Added progress bar for activate access key (openbmc#1) Error message displayed if fails to authenticate the user (openbmc#10) Memory page made HMC-managed independent (openbmc#15) Sorting fixed for status (openbmc#17) Sensors table now updating on refresh (openbmc#22) Secure LDAP is disabled when LDAP authentication disables (openbmc#23) Removed Service consoles page for read-only users (openbmc#14) Additional message added on Disable SSH (openbmc#30) Default partition value taken from translation file (openbmc#36) Updated password Max Limit (openbmc#26) New Error message displayed if fails to authenticate the user (openbmc#27) Added Status and roles values to the translation file (openbmc#31) Title translation (openbmc#34) Power values added to translation file (openbmc#32) Health and Date format taken from translation file (openbmc#37) Added possible property values in translation file (openbmc#39) Displaying System Anchor value (openbmc#40) Added Info tooltip to VirtualTPM (openbmc#47) Added max limit based on selected user (openbmc#46) Refresh only once after login (openbmc#42) Lamp test switch disabled once ON (openbmc#48) Tab names translated in Inventory page (openbmc#54) Using privilege values from the translation file (openbmc#56) Deconfiguration type is taken from translation file (openbmc#57) Fabric Adapter table showing Name (openbmc#55) PCIe topology overlapping fix (openbmc#53) Added Identity LED to Fabric Adapters (openbmc#49) Removed Error message from Accounts verification (openbmc#44) Dixsie Wolmers (14): Fix network settings defects - FQDN, link info, and MAC address (openbmc#113) Audit translation file (openbmc#115) Network settings - update DHCP section (openbmc#114) Add deconfiguration logs page (openbmc#121) Fix host console route (openbmc#157) Fix language dropdown on login page (openbmc#166) Network settings fixes - dhcp modal, edit ipv4, default gateway (openbmc#175) Update deconfig log table (openbmc#200) Update network settings ipv4 table (openbmc#199) Fix network settings hostname and IUM errors (openbmc#210) Add ability to edit asset tag (openbmc#211) Fix LDAP form values when LDAP disabled - SW546990 (openbmc#245) Fix deconfig records defects (openbmc#246) Update maintainers - Remove Dixsie and add Sandeepa (openbmc#286) aixt9n aixt9n (2): i18n: KO_KR: Drop latest translated files for webui-vue (openbmc#257) i18n: ES_ES: Drop latest translated files for webui-vue (openbmc#258) Change-Id: Ib5cb6cfccace5b718d22173ff1df4e8ce2a1e05c
stefanberger
pushed a commit
to stefanberger/openbmc
that referenced
this pull request
Aug 1, 2023
raviteja-b (1): Add Network Static Route D-bus Interface (openbmc#72) Change-Id: I20f4fe8ae068ae807a30a8492202be173f873410
geissonator
pushed a commit
that referenced
this pull request
Sep 1, 2023
IBM observed consistent hangs in the `uart_otp` tool when programming the OTP image into the SoC. This was root-caused by Aspeed: > Message-ID: <TYZPR06MB677027C95FCFABCDA6F81C4D800DA@TYZPR06MB6770.apcprd06.prod.outlook.com> > From: Neal Liu <neal_liu@aspeedtech.com> > Subject: Server Management technical issue by Rose.Drehmel@us.ibm.com > > Hi Andrew, > > It’s okay, I found the problem. > > The utility timeout is because it programs key retire bits in > OTPCFG4[7:0] without enabling secure boot. > > In the case of secure boot is enabled, the hardware would detect the > current boot up key number #id, and it can only retire the number > which is smaller than the current boot up key #id. > If not, the OTP status will keep busy, and the utility stocks in > polling loop. > > If you still want to disable key #0 without enabling secure boot, > OTPCFG0[5] can be another option for you. > > I also provide a new programmer.bin to fix this infinite loop problem > in case user thought BMC is crashed. > > You can try it with this command: > > $ uart_otp -s 2600 -p ast2600_otp_programmer.bin /dev/ttyUSBx > > Thanks > > Best Regards, > > -Neal In discussion with Chris we determined that we were not intentionally attempting to retire the development / low-security key, rather were just trying to be complete in the specification of our configuration. Neal responded to our request of how to avoid programming a key retirement in the configuration file: > Message-ID: <TYZPR06MB67700B238DB429A51E048E328010A@TYZPR06MB6770.apcprd06.prod.outlook.com> > From: Neal Liu <neal_liu@aspeedtech.com> > Subject: Server Management technical issue by Rose.Drehmel@us.ibm.com > > Hi Andrew, > > Just delete line #72 as unspecified value. > > Thanks > > Best Regards, > > -Neal >> >> From: Andrew Jeffery <andrewrj@au1.ibm.com> >> To: Neal Liu <neal_liu@aspeedtech.com> >> Subject: Re: Server Management technical issue by Rose.Drehmel@us.ibm.com >> >> Hi Neal, >> >> I've discussed your findings with Chris Engel, who is our platform >> security person. We determined that we do not want to mark the low >> security key as retired in the OTP as we're handling that via the >> FWSPIMISO strapping pin. >> >> What change should I make to our OTP configuration so that we don't >> retire key 0 during programming? >> >> Andrew Line 72 in this case refers to our OTP configuration file: https://github.com/openbmc/openbmc/blob/2a25492c13e2b768f94b864a51f84e82e4238aef/meta-ibm/recipes-bsp/u-boot/u-boot-aspeed-sdk/p10bmc/ibm.json#L72 Leave "Keys Retire ID" unspecified to avoid leaving the OTP engine busy. Cc: Chris Engel <cjengel@us.ibm.com> Cc: Rose Drehmel <Rose.Drehmel@us.ibm.com> Cc: Briana Foxworth <befoxwor@us.ibm.com> Cc: Nicole Nett <nschwart@us.ibm.com> Change-Id: Ib6b75a40f5debd5ba1166f0f69a07114b76d9c34 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.