Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial IPMI Net Function router #1

Merged
merged 1 commit into from Oct 8, 2015
Merged

Initial IPMI Net Function router #1

merged 1 commit into from Oct 8, 2015

Conversation

vishwabmc
Copy link
Contributor

No description provided.

williamspatrick
williamspatrick reviewed Sep 30, 2015
View reviewed changes
Makefile
CC=g++
CFLAGS = -I. -I/usr/include/gio-unix-2.0 -Wall -rdynamic
CFLAGS += $(shell pkg-config --cflags --libs glib-2.0 gio-unix-2.0)
CFLAGS += -DHOST_IPMI_LIB_PATH=\"/home/OpenBMC/1_EDUCATION/IPMI_DBUS/\"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have this default to /usr/lib/host-ipmid/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@vishwabmc
Copy link
Contributor Author

IPMI Patch set -2

@williamspatrick
Copy link
Member

Once we get these all reviewed, we will want to "squash" them down into a single commit. We don't need to preserve the patch history through this whole thing.

williamspatrick
williamspatrick reviewed Oct 6, 2015
View reviewed changes
ipmid.C
// Extract the map data onto appropriate containers
auto handler_and_context = iter->second;

rc = (handler_and_context.first) (netfn, cmd, request, response,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per demo, this should probably be &response[1] and then a line afterwards of response[0] = rc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@vishwabmc
Copy link
Contributor Author

Patch set - 3 with byte[0] as CC

@vishwabmc
Copy link
Contributor Author

Patch set - 3

@vishwabmc
Copy link
Contributor Author

Patch set 4

@williamspatrick
Copy link
Member

@vishwabmc - I'm not sure what happened on your end here. The commit 'patch set 4' is a merge commit, but also has changes to it. 'git-format-patch', which is what my tool uses to mirror to the mailing list doesn't handle merge commits with changes. Can you run the following to fix up your whole branch?

git diff 48e9b > IPMI.patch
git reset 48e9b --hard
git apply IPMI.patch
git add *.[ChH] Makefile
git commit -c ce34f8

williamspatrick added a commit that referenced this pull request Oct 8, 2015
@williamspatrick
Merge pull request #1 from vishwabmc/master
66910b3 
Initial IPMI Net Function router
@williamspatrick williamspatrick merged commit 66910b3 into openbmc:master Oct 8, 2015
geissonator pushed a commit that referenced this pull request Nov 20, 2018
@apuli1
IPMI Channel commands implementation
071f3f2 
IPMI Channel commands implemenation - squashed

commit e9a75d8dd6e89d17381f0310c7930586c6b79996
Author: AppaRao Puli <apparao.puli@intel.com>
Date:   Thu Jul 5 14:47:22 2018 +0530

    Channel layer separation

    De-coupling the channel management from ipmi channel commands
    implementation. This gives flexibility to load only needed
    stuff in different modules(host-ipmi or netipmid)

    Change-Id: Ib334562beb9325f7768ed6a15475cae15af17b19
    Signed-off-by: AppaRao Puli <apparao.puli@intel.com>
    Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

commit 726ddf2af678ea6773f4b4b918fbd49be8c83e6a
Author: AppaRao Puli <apparao.puli@intel.com>
Date:   Thu May 24 16:45:30 2018 +0530

    IPMI Channel commands implementation

    Following IPMI channel commands are implemented.
     1) Set channel access (0x40)
     2) Get channel access (0x41)
     3) Get channel info (0x42)

    Also added code supported for LAN configuration parameters
     1) Authentication Type Support (selector #1)
     2) Authentication Type Enables (selector #2)

    Change-Id: Ic4156378c7756eca383dc3da52114fd119346ca6
    Signed-off-by: AppaRao Puli <apparao.puli@intel.com>
    Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

Change-Id: Ic4156378c7756eca383dc3da52114fd119346ca6
Signed-off-by: AppaRao Puli <apparao.puli@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
geissonator pushed a commit to geissonator/phosphor-host-ipmid that referenced this pull request Aug 5, 2020
@rfrandse
Merge pull request openbmc#1 from tomjoseph83/SW467470
2d23771 
SW467470: Fix IPMI restricted mode operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vishwabmc @williamspatrick @bradbishop