dbus interface fixes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have reviewed this pull request and find it favorable |
|
Tested in qemu, works as described |
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Currently, the IPMI daemon will only receive messages from a specific (arbitrary) object path that the debug daemon used. Instead, we should be listening to any signal that matches our interface (org.openbmc.HostIpmi.ReceivedMessage). When replying to the message, we should be using the signal sender info to properly address the reply method. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
With the updated HostIpmi dbus interface, netfns are not packed with LUNs, and the CC is separate from the data. This means we no longer have to define NETFN_* as arbitrarily shifted, and we have the added bonus of replying to messages where lun != 0. We may want to separate the CC returned from the handlers in future too. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Curently, if I have no ipmi_lib_path, ipmid crashes: $ ./ipmid Registering handler:[/usr/lib/host-ipmid/H���dH��%(] ERROR opening [/usr/lib/host-ipmid/H���dH��%(]: /usr/lib/host-ipmid/H���dH��%(: cannot open shared object file: No such file or directory *** Error in `./ipmid': munmap_chunk(): invalid pointer: 0x0000000000401eb6 *** Aborted (core dumped) We need to check for the error case of a scandir(). Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, I can get ipmid talking to our dbus-enabled ipmitool.