Fix memory leak in good paths in ipmid #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -203,6 +203,7 @@ ipmi_ret_t ipmi_app_get_device_guid(ipmi_netfn_t netfn, ipmi_cmd_t cmd, | |||
|
|
|||
| sd_bus_error_free(&error); | |||
| sd_bus_message_unref(m); | |||
| sd_bus_message_unref(reply); | |||
There was a problem hiding this comment.
should be:
reply = sd_bus_message_unref(reply);
This will ensure reply is correct for subsequent calls.
Also the unref should be done after each sd_bus_call.
vishwabmc
force-pushed
the
master
branch
3 times, most recently
from
21eff00
to
30d19fa
Compare
…cases the reply was not unref'ed --signed off by vishwanath@in.ibm.com---
nkskjames
added a commit
that referenced
this pull request
Mar 5, 2016
Fix memory leak in good paths in ipmid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still leaks to be fixed in bad path.. this is a good path only.