Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors finding openbmc_path #75 #86

Merged
merged 1 commit into from May 24, 2016

Conversation

williamli80
Copy link
Contributor

@williamli80 williamli80 commented May 12, 2016

1.Check return value properly.

Signed-off-by: Nan Li bjlinan@cn.ibm.com


This change is Reviewable

@causten
Copy link
Member

causten commented May 12, 2016

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


sensorhandler.C, line 231 [r1] (raw file):


final:

blank line?


Comments from Reviewable

@williamli80
Copy link
Contributor Author

Thanks Chris. Fixed.

@causten
Copy link
Member

causten commented May 13, 2016

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@anoo1
Copy link
Contributor

anoo1 commented May 16, 2016

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@anoo1
Copy link
Contributor

anoo1 commented May 16, 2016

:lgtm:

Previously, williamli80 (William Li ( Nan Li, 李楠)) wrote…

Thanks Chris. Fixed.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@anoo1
Copy link
Contributor

anoo1 commented May 16, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion.


sensorhandler.C, line 231 [r1] (raw file):

Previously, causten (Chris Austen) wrote…

blank line?


Nan has fixed in latest PR.


Comments from Reviewable

@causten
Copy link
Member

causten commented May 16, 2016

looks good:lgtm:

Previously, anoo1 wrote…

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

1.Check return value properly.

Signed-off-by: Nan Li <bjlinan@cn.ibm.com>
@williamli80
Copy link
Contributor Author

Hi, updated. Please review.

@williamspatrick williamspatrick merged commit d32939e into openbmc:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants