Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable networkd unit tests #23

Closed
ratagupt opened this issue Aug 10, 2018 · 1 comment
Closed

Re-enable networkd unit tests #23

ratagupt opened this issue Aug 10, 2018 · 1 comment

Comments

@ratagupt
Copy link
Contributor

This is a regression caused by the sdbusplus changes which starts throwing exception during sd_bus_call create.

With this defect we have to re-enable the unit tests.
geissonator pushed a commit that referenced this issue Aug 13, 2018
Disable unit tests as CI is broken
c582c05 
unit tests is broken due to the
commit(https://gerrit.openbmc-project.xyz/#/c/10566)
in sdbusplus repo which starts throwing exception
after sdbusplus::bus::call.

Need to write mock class for sdbusplus methods.

Re-enable the unit test would be done with the following
issue #23

Change-Id: Ib113a65d63d14be1e9e57191851df23ffe8bc518
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
@ratagupt
Copy link
Contributor Author

unit tests is already enabled.

eddiejames pushed a commit to eddiejames/phosphor-networkd that referenced this issue Sep 22, 2020
@amboar @bradbishop
test_rtnetlink: Force bus object to outlive TestRtNetlink lifetime
4aa1378 
We were hitting a SEGFAULT by nullptr dereference in the WithSingleInterface
test when calling sd_bus_ref() via the timer callback with code generated at
-O2 from Ubuntu Artful's gcc-7.2.0:

Running main() from gtest_main.cc
Note: Google Test filter = TestRtNetlink.WithSingleInterface
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from TestRtNetlink
[ RUN      ] TestRtNetlink.WithSingleInterface
ASAN:DEADLYSIGNAL
=================================================================
==19427==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f8a944922ca bp 0x0fffd7e37fc2 sp 0x7ffebf1bfda8 T0)
==19427==The signal is caused by a READ memory access.
==19427==Hint: address points to the zero page.
    #0 0x7f8a944922c9 in sd_bus_ref (/lib/x86_64-linux-gnu/libsystemd.so.0+0x2e2c9)
    openbmc#1 0x7f8a93a5c616 in sdbusplus::bus::bus::bus(sd_bus*) /usr/local/include/sdbusplus/bus.hpp:340
    openbmc#2 0x7f8a93a5c616 in sdbusplus::server::interface::interface::interface(sdbusplus::bus::bus&, char const*, char const*, sd_bus_vtable const*, void*) /usr/local/include/sdbusplus/server/interface.hpp:61
...
    openbmc#16 0x559d611755e7 in phosphor::network::Manager::createInterfaces() ../network_manager.cpp:151
    openbmc#17 0x559d61178e12 in phosphor::network::Manager::createChildObjects() ../network_manager.cpp:166
    openbmc#18 0x559d611ed59b in std::function<void ()>::operator()() const /usr/include/c++/7/bits/std_function.h:706
    openbmc#19 0x559d611ed59b in phosphor::network::Timer::timeoutHandler(sd_event_source*, unsigned long, void*) ../timer.cpp:72
    openbmc#20 0x7f8a9448e80d  (/lib/x86_64-linux-gnu/libsystemd.so.0+0x2a80d)
    openbmc#21 0x7f8a944903e9 in sd_event_dispatch (/lib/x86_64-linux-gnu/libsystemd.so.0+0x2c3e9)
    openbmc#22 0x7f8a94490566 in sd_event_run (/lib/x86_64-linux-gnu/libsystemd.so.0+0x2c566)
    openbmc#23 0x559d610e122e in phosphor::network::TestRtNetlink_WithSingleInterface_Test::TestBody() /tmp/openbmc-build-scripts.wUcrvx/phosphor-networkd/test/test_rtnetlink.cpp:135
...

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libsystemd.so.0+0x2e2c9) in sd_bus_ref
==19427==ABORTING

Move the bus storage to namespace scope alongside the Manager to avoid it
getting cleaned up before the callback fires.

Change-Id: I3126d0b7b92fb6e66d82f9e32b43a52e44356884
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
anoo1 pushed a commit to anoo1/phosphor-networkd that referenced this issue Apr 27, 2022
@asmithakarun
Remove ifcount support (openbmc#23)
5e89b27 
This pr removes the support for vmi_if_count (which is used to
determine the number of vmi interfaces enabled) as it's deprecated
and phyp no longer consumes it.

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I6a97d7a2013b1e4d5228e81d878ae88a570dc681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ratagupt