Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid introspection during discovery #11

Merged
merged 1 commit into from May 19, 2016
Merged

Avoid introspection during discovery #11

merged 1 commit into from May 19, 2016

Conversation

bradbishop
Copy link
Member

@bradbishop bradbishop commented May 16, 2016

Speed up discovery by calling GetManagedObjects on any ObjectManagers.
Fall back on introspection for parent elements or services that don't
implement one.


This change is Reviewable

Speed up discovery by calling GetManagedObjects on any ObjectManagers.
Fall back on introspection for parent elements or services that don't
implement one.
@causten
Copy link
Member

causten commented May 16, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


phosphor-mapper, line 94 [r1] (raw file):

                    bool,
                    [x.attrib.get('name') for x in root.findall('node')])
                children = [

does this negate what children was on the line before?


Comments from Reviewable

@bradbishop
Copy link
Member Author

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


phosphor-mapper, line 94 [r1] (raw file):

Previously, causten (Chris Austen) wrote…

does this negate what children was on the line before?


yes - that was the intent.


Comments from Reviewable

@causten
Copy link
Member

causten commented May 17, 2016

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@williamspatrick williamspatrick merged commit f7aa902 into openbmc:master May 19, 2016
@bradbishop bradbishop deleted the no-introspection branch May 20, 2016 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants