Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC online path is hardcoded #33

Closed
nkskjames opened this issue Jan 30, 2016 · 1 comment
Closed

OCC online path is hardcoded #33

nkskjames opened this issue Jan 30, 2016 · 1 comment
Labels
enhancement

Comments

@nkskjames
Copy link
Contributor

When the OCC becomes active, the sensor currently sets the online attribute to 1 for OCC hwmon driver. It is using hardcoded path and is customized for Barreleye. Need to remove hardcoding.
@nkskjames
Copy link
Contributor Author

After revisiting, the main issue is that sensor_manager is system specific. It instantiates sensors that are specific to a particular system. Need to make generic.

adamliyi added a commit to adamliyi/skeleton that referenced this issue May 5, 2016
@adamliyi
[skeleton]: Fix hard-coded path name when creating sensor object
fbfb53d 
This patch fixes skeleton issue: openbmc#33
The non-poll sensors have system specific properties. Define the sensor properties
in System files, and generate sensor object dynamically.
@adamliyi adamliyi mentioned this issue May 5, 2016
Merged
adamliyi added a commit to adamliyi/skeleton that referenced this issue May 9, 2016
@adamliyi
[skeleton]: Fix hard-coded path name when creating sensor object
54decc8 
This patch fixes skeleton issue: openbmc#33
The non-poll sensors have system specific properties. Define the sensor properties
in System files, and generate sensor object dynamically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkskjames