Add fan control algorithm #59
Conversation
Fill in the threshold settings for CPU and DIMM based on the table from thermal team
Fill in the threshold settings for CPU and DIMM based on the table from thermal team
This reverts commit b78d667.
Add lm75 outlet temperature sensor on I2C-6 for Barreleye
Add I2C-6 lm75 outlet temperature sensor
After we enable I2C-6 lm75 outlet sensor in device stree, the hwmon ID of PowerCap won't be 3 anymore. So we have to modify it as real ID.
Modify the hard-coded hwmon ID for PowerCap
|
hwmons_barreleye.c is not used anymore. The hwmon directories are scanned and matched up to entries in Barreleye.py. So remove that change. I will remove those files from repository. Also the SCU changes have already been done in kernel and need to be removed here. Your new 'info' program should probably go in a different repository. We should discuss. |
Fill in the threshold settings for CPU and DIMM based on the Barreleye_sys_behaivor_Thermal_table_x03 from thermal team
…eleton into cpu_dimm_threshold Conflicts: bin/Barreleye.py
Fill in the new threshold settings for CPU and DIMM
Add fan control algorithm
|
Thanks for your code review Norm. In v0.6-stable, hwmons_barreleye.c is still there, right? Setup FUNC_MODE[2:0] is just a temproray workaround for find out Eth1 loss issue root cause, we will remove that. @ken1029 @johnhcwang Please note Norm's comment. Thanks. |
|
yes, the file is still there, but not used. the func_mode gpio workarounds are now in the kernel. you don't need to do those here. Also, can you please put each new function or fix into it's own pull request so we can independently review and merge them? Some items will be easier than others. |
The default value is 0, so we have to configure it to avoid the critical assertion while power off.
1. Multi-processes if we call fan_algorithm.py every HOST_POWERED state 2. Occupy the memory if we don't unref sdbus message
1. Support FAN tach sensors 2. Remove shut down action from info. It'll be done by Emergency ShutDown.
Keep the original design from v2.10
The shutdown action have to execute by info instead of emergency shutdown, otherwise probably can't log the event in time. So disable emergency for all CPU core in Barreleye.py. The bast implementation is do log in EmergencyShutdown function. Improve in the future.
Fix memory leak in fan_algorithm and info/Support FAN tach sensors and LED/Generate thermaltrip event
This reverts commit 0428fb4.
Conflicts: Makefile objects/button_power_obj.c objects/control_bmc_barreleye.c objects/control_bmc_obj.c
This reverts commit c648d4d. Conflicts: objects/control_bmc_barreleye.c objects/control_bmc_obj.c
|
Hi Ken, in order to merge this, it needs a little more cleanup of the commit history. Some commits can be squashed, some can be remove like the ones that just revert a previous commit. This will require using "git rebase --interactive". If you need help one of us can help clean up. Let us know. |
|
how's the git changes coming along? |
|
Hi @Kenthliu. We want to get this functionaltiy merged in, but the commits need a bit of work You need to rebase on the latest master. You also need to squish your commits down so the history is clean. Pretend you're a new developer reading the output of Feel free to ask any questions if you need help. |
|
Please submit through Gerrit if needed. |
This change is