Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory upload fixes #98

Merged
merged 3 commits into from
Jun 6, 2016
Merged

Inventory upload fixes #98

merged 3 commits into from
Jun 6, 2016

Conversation

bradbishop
Copy link
Member

@bradbishop bradbishop commented Jun 6, 2016

This patchset aims to correct a number of issues with the timing of kicking off the inventory upload procedure.


This change is Reviewable

Cut down on dbus traffic by keeping a little cache of hwmon sensor
attributes.  Only call the sensor manager if the value has actually
changed.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
A wrapper script for use with the skeleton state management
infrastructure that runs an application and then emits a
goto system state signal.  This removes the need for applications
to embed state transition logic.

This is a hack to enable inventory upload until a more complete
skeleton/systemd state management infrastructure is created.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Insert the inventory upload step into the boot sequence.

The current triggers ( host powered off and bmc boot )
don't handle a BMC reset while the host is running.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
@williamspatrick williamspatrick merged commit b2f3fd7 into openbmc:master Jun 6, 2016
@bradbishop bradbishop deleted the upload-state branch June 9, 2016 05:28
@johnhcwang
Copy link

johnhcwang commented Jun 30, 2016

Hi @bradbishop ,
We noticed there is no any data in most of the inventory (BIOS version, DIMM ...) with v1.0.1 on Barreleye.

$ curl -s -c cjar -b cjar -k https://10.38.3.173/org/openbmc/inventory/system/bios
{
  "data": {
    "fault": "False", 
    "fru_type": "SYSTEM", 
    "is_fru": 1, 
    "present": "True", 
    "version": ""
  }, 
  "message": "200 OK", 
  "status": "ok"
} 
# cat /etc/os-release
ID=openbmc-phosphor
NAME=Phosphor OpenBMC (Phosphor OpenBMC Project Reference Distro)
VERSION=0.1.0 (jethro)
VERSION_ID=v1.0.1-dirty
PRETTY_NAME=Phosphor OpenBMC (Phosphor OpenBMC Project Reference Distro) 0.1.0 (jethro)
BUILD_ID=v1.0.1

# obmcutil state
 = HOST_BOOTED
#

Attach some messages in journal log for your information.

barreleye system_manager.py[956]: Running System State: HOST_POWERED_ON
barreleye system_manager.py[956]: Starting process: /usr/sbin/goto_system_state.py INVENTORY_UPLOADED inventory_upload.py: inventory_upload
ftgmac100: NCSI interface up
barreleye kernel: ftgmac100: NCSI interface up
barreleye kernel[949]: ftgmac100: NCSI interface up
barreleye system_manager.py[956]: ERROR (name_properties): "name" property in /bmc/inventory/hdd_backplane is incorrect ("BARRELEYE Exander" instead of base node name)
barreleye system_manager.py[956]: ERROR (name_properties): "name" property in /bmc/inventory/sas_expander is incorrect ("BARRELEYE BPx15" instead of base node name)
barreleye system_manager.py[956]: ERROR (name_properties): "name" property in /bmc/inventory/misc is incorrect ("BARRELEYE MB" instead of base node name)
barreleye system_manager.py[956]: ERROR: Input tree has errors, aborting (use -f to force output)
barreleye system_manager.py[956]: Cannot read attributes: /sys/class/hwmon/hwmon1/in6_input
barreleye system_manager.py[956]: About to erase 0x01e75000..0x01e7e000 !
barreleye system_manager.py[956]: Erasing...
barreleye system_manager.py[956]: [569B blob data]
barreleye system_manager.py[956]: About to program "/tmp/tmptfbw9C" at 0x01e75000..0x01e7e000 !
barreleye system_manager.py[956]: Programming & Verifying...
barreleye system_manager.py[956]: [                                                  ] 0%
barreleye system_manager.py[956]: Updating actual size in partition header...
barreleye system_manager.py[956]: Uploading inventory to PNOR in dtb format...
barreleye system_manager.py[956]: Running System State: INVENTORY_UPLOADED
barreleye system_manager.py[956]: Starting process: /usr/sbin/pcie_slot_present.exe: pcie_present
barreleye system_manager.py[956]: Setting fans to max
barreleye system_manager.py[956]: Booting host

@Kenthliu
Copy link
Contributor

Duplicat issue with openbmc/openbmc#423

@johnhcwang
Copy link

Oops!! Let us track this issue with Kens'.

JasonLuo701 pushed a commit to JasonLuo701/skeleton that referenced this pull request Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants