Add permissioned markets #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
metaproph3t
commented
May 23, 2023
metaproph3t
commented
- address Permissioned markets #33
metaproph3t
force-pushed
the
feature/permissioned-markets
branch
4 times, most recently
from
79264a1
to
232da79
Compare
For [permissioned markets](#33), we need to store the `Pubkey`s of market authorities. Assuming that we do not want to require *all* markets to be permissioned, we will need to store both (1) whether or not this market has an authority and (2) the authority, if any. Traditionally, this would be done in an `Option<Pubkey>`, but we use [zero copy deserialization](https://docs.rs/anchor-lang/latest/anchor_lang/prelude/attr.zero_copy.html), which requires all types to implement `bytemuck::Pod`. `std::option::Option<T>` does not implement `Pod`, and because of the way enum bit patterns work in Rust, it cannot. So we need to add a custom option implementation that *does* implement `Pod`.
Store the various admins, such as `fee_collector`, `close_authority`, etc. inside the `Market` struct.
If an `open_orders_admin` is set inside a `Market`, require all orders submitted to that market to have the signature of the `open_orders_admin`.
Add an optional `consume_events_admin` to the market struct that, if present, must sign off on any consume event instruction.
metaproph3t
force-pushed
the
feature/permissioned-markets
branch
4 times, most recently
from
2824ff8
to
487dc51
Compare
Closed
metaproph3t
force-pushed
the
feature/permissioned-markets
branch
2 times, most recently
from
b994ad8
to
2649484
Compare
binyebarwe
reviewed
May 25, 2023
binyebarwe
reviewed
May 25, 2023
| /// Admin who can collect fees from the market | ||
| pub collect_fee_admin: Pubkey, | ||
| /// Admin who can manage the oracle | ||
| pub manage_oracle_admin: PodOption<Pubkey>, |
There was a problem hiding this comment.
This admin would be able to manage the oracle, which currently just means setting the stub oracle. I included it in case there was a use for it later (e.g., a change oracle instruction), but on second thought it seems that it should be removed from this PR and included later only if there's a defined use for it.
Certainly, I will fix this, sir. |
metaproph3t
force-pushed
the
feature/permissioned-markets
branch
2 times, most recently
from
f799a5a
to
e0e1ecc
Compare
binyebarwe
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.