OBPIH-3776 Add download orders option #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was struggling with finding a way how to propely round the
order.totalandorder.totalNormalizedso it looks in the .csv as in the table of list orders - I hope that rounding it to 2 decimal places as in the table was a good approach.I was also thinking whether I should download all orders (obviously with applied filter, but what I mean is that if there are 4 pages, the 4 pages are downloaded at one time) or only those visible at the moment (10 rows) in the table should be downloaded, but I kept the approach of already done report which is "Download order line details" where all rows are downloaded.