OBPIH-4461 Add view for OrderItem derived status #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added two views. First one order_item_summary "extended" with more JOINs, based on the already existing views related to the Order derived status (inside the order-summary-view.sql). The other one order_item_details is a bit simplified. There is option to check tables with results from both views on the '(...)/openboxes/order/orderItemSummaryList' and on the '(...)/openboxes/order/orderItemDetailsList'. The key difference between those two is that we won't be able do an extensive filtering on the simplified one, where on the list from the order_item_summary view we can basically filter on every field we have there. After performance testing/comparison we can decide which option we want to be there and the other one will be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two views. First one order_item_summary "extended" with more JOINs, based on the already existing views related to the Order derived status (inside the order-summary-view.sql). The other one order_item_details is a bit simplified. There is option to check tables with results from both views on the '(...)/openboxes/order/orderItemSummaryList' and on the '(...)/openboxes/order/orderItemDetailsList'. The key difference between those two is that we won't be able do an extensive filtering on the simplified one, where on the list from the order_item_summary view we can basically filter on every field we have there. After performance testing/comparison we can decide which option we want to be there and the other one will be removed.