Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBPIH-4562 Items balance dialog in transaction report doesn't work #3321

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

kchelstowski
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@awalkowiak awalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kchelstowski I think this might be another issue caused by the codec change. I am not sure how we could deal with it on the 1.3.9, but you could try with encodeAsUrl() or raw() on url in the controller

@kchelstowski
Copy link
Collaborator Author

@awalkowiak I tried the solutions you asked me to check, but none of them works - the encodeAsURL() both tried in controller and at .gsp gave url like this:

%2Fopenboxes%2Fjson%2FgetTransactionReportDetails%3FstartDate%3D06%252F01%252F2020%26productCode%3D10001%26locationId%3D8a8a9e9665c4f59d0165c5505245002b%26endDate%3D06%252F27%252F2022

which was giving an error on the frontend side.
The raw() didn't work as well - gave the error - "No signature of method".

toString() - didn't change anything

I let you decide whether it is worth to figure it out further or we should accept my solution with replace

@@ -42,10 +42,11 @@
"sPaginationType": "two_button",
"sAjaxSource": "${url}",
"fnServerData": function ( sSource, aoData, fnCallback ) {
const sSourceParsed = sSource.replaceAll("&", "&");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am gonna merge this version as a short-term remedy, but I'll create a tech debt ticket to further investigate this issue.

@awalkowiak awalkowiak merged commit 7b0f12b into develop Jun 27, 2022
@awalkowiak awalkowiak deleted the OBPIH-4562 branch June 27, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants