OBPIH-4446 Allow deactivation of budget codes #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kchelstowski looks like I forgot to add the order_item_summary view to the drop-all-views sql, please add this here: https://github.com/openboxes/openboxes/blob/develop/grails-app/migrations/views/drop-all-views.xml#L20 cc @jmiranda, @DaRoTP |
kchelstowski
added
work in progress
do not merge
and removed
blocker
needs attention
labels
kchelstowski
force-pushed
the
OBPIH-4446
branch
2 times, most recently
from
94bb36f
to
2f521bc
Compare
awalkowiak
requested changes
Jul 4, 2022
| DROP VIEW IF EXISTS order_payment_status_from_shipments; | ||
| DROP VIEW IF EXISTS order_payment_status_from_adjustments; | ||
| DROP VIEW IF EXISTS order_summary; | ||
| DROP VIEW IF EXISTS order_item_summary; |
There was a problem hiding this comment.
All other views are above. The only one missing was the order_item_summary (add this one next to the others related above). No need to drop the other views twice ;)
awalkowiak
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a PR for @jmiranda to investigate the issue I've faced today