OBPIH-4580 Add supplier information to inbound packing list download … #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalkowiak
requested changes
Jul 6, 2022
| manufacturerOutput += supplier.manufacturer | ||
| manufacturerCodeOutput += supplier.manufacturerCode | ||
| } | ||
| row.createCell(CELL_INDEX).setCellValue(supplierOutput) |
There was a problem hiding this comment.
row.createCell(CELL_INDEX).setCellValue(supplier?.supplierCode ?: '')
| row.createCell(CELL_INDEX).setCellValue(supplierOutput) | ||
| row.getCell(CELL_INDEX++).setCellStyle(tableDataCenterStyle) | ||
|
|
||
| row.createCell(CELL_INDEX).setCellValue(manufacturerOutput) |
There was a problem hiding this comment.
row.createCell(CELL_INDEX).setCellValue(supplier?.manufacturer ?: '')
| row.createCell(CELL_INDEX).setCellValue(manufacturerOutput) | ||
| row.getCell(CELL_INDEX++).setCellStyle(tableDataCenterStyle) | ||
|
|
||
| row.createCell(CELL_INDEX).setCellValue(manufacturerCodeOutput) |
There was a problem hiding this comment.
row.createCell(CELL_INDEX).setCellValue(supplier?.manufacturerCode ?: '')
kchelstowski
commented
Jul 7, 2022
| row.getCell(CELL_INDEX++).setCellStyle(tableDataCenterStyle) | ||
|
|
||
| row.createCell(CELL_INDEX).setCellValue(manufacturerOutput) | ||
| row.createCell(CELL_INDEX).setCellValue(supplier?.manufacturer?.toString() ?: '') |
There was a problem hiding this comment.
toString() was neccessary, because supplier.manufacturer is of Organization class and in this version it was said that
setCellValue cannot be applied to '(java.io.Serializable & java.lang.Comparable<? extends java.io.Serializable & java.lang.Comparable<?>>)'
awalkowiak
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(excel)
Those empty strings, eg.
are made and added to cell even if they are empty, because without at least empty string being added to the cell, the cell has no border, which would not be acceptable.