WIP: OBPIH-4169 Refactor role configuration in RoleFilters to create … #3351
Conversation
…explicit delete / remove actions
grails-app/conf/Config.groovy
Outdated
|
|
||
| openboxes.security.rbac.rules = [ | ||
| [controller: 'auth', actions: ['*'], access: [RoleType.ROLE_ANONYMOUS]], | ||
| [controller: 'dashboard', actions: ['getExpirationSummary'], access: [RoleType.ROLE_AUTHENTICATED]], |
There was a problem hiding this comment.
Is this one required? Below you have the [controller: 'dashboard', actions: ['*'], access: [RoleType.ROLE_AUTHENTICATED]]
There was a problem hiding this comment.
None of them are required. We just need rules related to the delete/removes. Or we need an empty rules list that can be overriden via openboxes-config.groovy.
There was a problem hiding this comment.
@awalkowiak Let's remove everything except for delete, remove, discard, dismantle, etc. And we can add a catchall for each of them like the last two rules.
|
@jmiranda I think this one looks good. There is one 'redundant' row in the config. Other than that do you want to add something to it? Or is it ready to be merged atm? |
| @@ -32,6 +32,11 @@ class ApiController { | |||
| def grailsApplication | |||
| def messageSource | |||
|
|
|||
| def rbacRules = { | |||
There was a problem hiding this comment.
We should get rid of this. This was just for testing.
…ns that relate to data removal
…explicit delete / remove actions