OBPIH-4002 Admins cannot delete documents #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
requested changes
Aug 5, 2022
| <g:link action="deleteDocument" id="${documentInstance.id}" params="['order.id':orderInstance?.id]" onclick="return confirm('${warehouse.message(code: 'default.button.delete.confirm.message', default: 'Are you sure?')}');"> | ||
| <img src="${createLinkTo(dir:'images/icons',file:'trash.png')}" alt="Delete" /> | ||
| </g:link> | ||
| <g:isUserAdmin> |
There was a problem hiding this comment.
As I mentioned in the previous PR, we should try not to use the static isUser* taglib any longer because these are configurable. The best approach would be to modify the LinkTagLib to handle this. Or always show the link and allow the auth mechanism to determine with the user has access.
awalkowiak
approved these changes
Aug 9, 2022
kchelstowski
force-pushed
the
OBPIH-4002
branch
from
38d7047
to
cce9978
Compare
kchelstowski
force-pushed
the
OBPIH-4002
branch
from
cce9978
to
ca632f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making admins be able to delete documents from PO