OBPIH-4677 PO with canceled items only should not be visible on PO sh… #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
approved these changes
Aug 16, 2022
| orderNumber: it.orderNumber | ||
| ] | ||
| } | ||
| ] as JSON) |
There was a problem hiding this comment.
I'd feel more comfortable if this was either
def data = ...
render([data: data] as JSON)
There was a problem hiding this comment.
In fact, the code here is complex enough that it probably deserves to be migrated to the service so we can write tests for it. Since you haven't changed much about the original code (aside from formatting), we can leave it as-is, but I'd like to refactor this a bit when we get a chance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ipment dropdown