OBPIH-4764 bin import incorrect bin location type assigned #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalkowiak
requested changes
Aug 25, 2022
| @@ -476,7 +476,7 @@ class LocationService { | |||
| throw new ValidationException("location.cannotImportBinLocationsWithoutParentLocation.message") | |||
| } | |||
|
|
|||
| LocationType defaultLocationType = LocationType.findByLocationTypeCode(LocationTypeCode.BIN_LOCATION) | |||
| LocationType defaultLocationType = LocationType.findByLocationTypeCodeAndName(LocationTypeCode.BIN_LOCATION, "Bin Location") | |||
There was a problem hiding this comment.
This is the wrong approach. We do not have certainty that in every instance of OB the naming will remain as it is here. I think we could try to take the oldest (date created) location type with code BIN_LOCATION.
Additionally the same issue occurs within the regular location import in the locationApiController.importCsv, because there is findByNameLike(name + '%') which also takes the newest record. Perhaps there we could get rid of like with % wildcard option.
drodzewicz
force-pushed
the
OBPIH-4764-bin-import-incorrect-bin-location-type-assigned
branch
from
b52b535
to
2879c9b
Compare
awalkowiak
approved these changes
Aug 25, 2022
awalkowiak
deleted the
OBPIH-4764-bin-import-incorrect-bin-location-type-assigned
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.