OBPIH-3979 Can ship PO shipment when not in destination or central purchasing location #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodzewicz
force-pushed
the
OBPIH-3979-can-ship-po-shipment-when-not-in-destination-or-central-purchasing-location
branch
from
be53713
to
d485fb4
Compare
awalkowiak
reviewed
Sep 7, 2022
| @@ -245,7 +245,7 @@ class StockMovement { | |||
| boolean isDepot = origin?.isDepot() | |||
| boolean isCentralPurchasingEnabled = currentLocation?.supports(ActivityCode.ENABLE_CENTRAL_PURCHASING) | |||
|
|
|||
| return !hasBeenReceived() && !hasBeenPartiallyReceived() && (isSameOrigin || (!isDepot && isSameDestination) || !isPending() || isElectronicType() || (isCentralPurchasingEnabled && isFromOrder)) | |||
| return !hasBeenReceived() && !hasBeenPartiallyReceived() && (isSameOrigin || (!isDepot && isSameDestination) || (!isFromOrder && !isPending()) || isElectronicType() || (isCentralPurchasingEnabled && isFromOrder)) | |||
There was a problem hiding this comment.
This line needs some refactoring, but I have no clear idea how we could improve it...
There was a problem hiding this comment.
(I added a todo in the code)
awalkowiak
approved these changes
Sep 7, 2022
awalkowiak
deleted the
OBPIH-3979-can-ship-po-shipment-when-not-in-destination-or-central-purchasing-location
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.