OBPIH-4705 Fix Location chooser button #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
drodzewicz
commented
Sep 9, 2022
drodzewicz
commented
- fix long location name text overlay
- fix some padding/margin styling
- added ability to close modal on click outside
- fix long location name text overlay - fix some padding/margin styling - added ability to close modal on click outside
drodzewicz
force-pushed
the
OBPIH-4705-location-functionality
branch
from
7241491
to
004cbd2
Compare
drodzewicz
requested review from
awalkowiak and
kchelstowski
and removed request for
awalkowiak
awalkowiak
reviewed
Sep 9, 2022
| @@ -999,7 +999,7 @@ div.crossed-out .table-inner-row:before { | |||
| } | |||
|
|
|||
| &::-webkit-scrollbar-thumb { | |||
| background-color: var(--blue-300); | |||
| background-color: var(--blue-301); | |||
There was a problem hiding this comment.
It is not a typo, it is a different color
Unfortunately this color was not specified on the color pallet on figma so I named it myself.
Named it blue-301 because it is very similar to already defined color blue-300
awalkowiak
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.