OBPIH-4710 Create reusable filter component #3468
Conversation
…ents and their styles
|
|
||
| import Translate from 'utils/Translate'; | ||
|
|
||
| const ButtonPrimary = ({ label, defaultLabel, disabled }) => ( |
There was a problem hiding this comment.
The components ButtonPrimary and ButtonTransparent look identical to me and can probably be a single Button component with props and custom classes.
There was a problem hiding this comment.
This probably can be a global button component and not strictly connected to Filter
There was a problem hiding this comment.
Yeah, I agree but wanted to split them, but at one point thought that if they may be easier to use if they are separated.
As for second comment - they are global, I don't know why you think they aren't?
There was a problem hiding this comment.
Sorry I thought these button components are inside the Filter directory but they are in form-element which is alright.
But both of the ButtonPrimary and ButtonTransparent should be merged into one Button component that has props to modify it in a way that can create both ButtonPrimary and ButtonTransparent from Button
|
|
||
| </div> | ||
| <div className="submit-buttons"> | ||
| <button |
There was a problem hiding this comment.
Regarding the customButton component that you would be able to use here
There was a problem hiding this comment.
Oh, I forgot to delete this section as in the beginning I was just copying form from some other component. It should be (and will be) deleted of course.
| const [amountFilled, setAmountFilled] = useState(0); | ||
| const countFilled = (values) => { | ||
| // Calculate which object's values are not empty | ||
| setAmountFilled(Object.keys(values).filter(key => values[key]).length); |
There was a problem hiding this comment.
A better solution would probably be to do Object.values
Object.values(values).filter((val) => val).length
There was a problem hiding this comment.
but also remember about falsy values like 0.
If value of a filter will be 0 it will result as false during the filter and will not be counted
There was a problem hiding this comment.
that's nice point, I probably didn't consider this as I was only using string-like fields for testing. Thanks for that
|
@drodzewicz I made |
No description provided.