OBPIH-4734 Restyle date-picker #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
drodzewicz
commented
Sep 16, 2022
drodzewicz
commented
- restyle date picker popup
- restyle data picker input
- create a separate DateFilter component
- restyle date picker popup - restyle data picker input - create a separate DateFilter component
kchelstowski
requested changes
Sep 16, 2022
| const [isFocused, setIsFocused] = useState(false); | ||
|
|
||
| const onChangeHandler = (date) => { | ||
| const val = !date || typeof date === 'string' ? date : date.format(dateFormat); |
There was a problem hiding this comment.
I assume it is working how it should be, but could you explain what it is exactly doing?
There was a problem hiding this comment.
I copied this from the DateField component and looking at it again it looks unnecessary complicated so in the new commit I simplified it.
- fix relative path import in index.js - simplify onChangeHandler function - add selected date prop to DatePicker - fix eslint rule for button can be a child of button element
kchelstowski
approved these changes
Sep 19, 2022
awalkowiak
approved these changes
Sep 19, 2022
awalkowiak
deleted the
OBPIH-4734-restyling-filters-date-picker-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.