OBPIH-4769 Add list endpoint in Product API #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
reviewed
Oct 5, 2022
| @@ -249,7 +249,20 @@ class BootStrap { | |||
|
|
|||
|
|
|||
| JSON.registerObjectMarshaller(Product) { Product product -> | |||
| return product.toJson() | |||
| [ | |||
There was a problem hiding this comment.
Why are we moving these out of the Product class? I am trying to move all of these into the domain classes.
| @@ -46,6 +46,35 @@ class UrlMappings { | |||
| controller = { "categoryApi" } | |||
| action = [GET: "read", POST: "save", PUT: "save", DELETE: "delete"] | |||
| } | |||
|
|
|||
| // Category options for filters on product list page | |||
| "/api/categoryOptions"(parseRequest: true) { | |||
There was a problem hiding this comment.
Why not create their own APIs using the BaseDomainApiController? Or why not just use the generic API for these?
|
|
||
| def products = productService.getProducts(category, catalogs, tags, includeInactive, params) | ||
|
|
||
| if (params.format == 'csv') { |
There was a problem hiding this comment.
Do we need CSV handling on the API?
| @@ -56,7 +93,7 @@ class ProductApiController extends BaseDomainApiController { | |||
| render([data: data] as JSON) | |||
| } | |||
|
|
|||
| def list = { | |||
| def search = { | |||
There was a problem hiding this comment.
I think this might be a breaking change. The product API is already being used externally for things like the mobile app and other API clients so this might be a bad idea. In the future, please don't change existing endpoints unless we've had a discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.