OBPIH-4772 Invoice list (fixes after QA) #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodzewicz
approved these changes
Sep 26, 2022
…ilters by default on invoice list
kchelstowski
force-pushed
the
OBPIH-4772
branch
from
cc866f1
to
4fe1f78
Compare
awalkowiak
requested changes
Sep 26, 2022
| }, | ||
| ]; | ||
|
|
||
|
|
||
| const onFetchHandler = (state) => { | ||
| const offset = state.page > 0 ? (state.page) * state.pageSize : 0; | ||
| const sortKeyParser = (key) => { | ||
| // Property is named invoiceTypeCode, but in marshaller was renamed to invoiceType |
There was a problem hiding this comment.
Then rename it in the marshaller to the invoiceTypeCode
|
The problem with Search/Clear button if we wanted to refresh with the same filter values multiple times was that the state (filterParams) was not changed as after multiple submits we were providing the same values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.