OBPIH-4770 Create new product list #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodzewicz
requested changes
Sep 27, 2022
| const [filterParams, setFilterParams] = useState({}); | ||
|
|
||
| useEffect(() => { | ||
| props.fetchTranslations(props.locale, 'purchaseOrder'); |
There was a problem hiding this comment.
wrong translation fetched
change to
props.fetchTranslations(props.locale, 'productsList');
| label: 'react.productsList.includeSubcategories.label', | ||
| defaultMessage: 'Include all products in all subcategories', | ||
| attributes: { | ||
| filterElement: true, |
There was a problem hiding this comment.
what does the attribute filterElement: true do for CheckboxField ?
There was a problem hiding this comment.
it is added to filter form elements not to have to play around with position styles included in form-utils, so it is just to position filter elements, nothing functional.
There was a problem hiding this comment.
that's right I remember now. The naming implies that it has something to do with filtering, kind of misleading
drodzewicz
approved these changes
Sep 27, 2022
kchelstowski
force-pushed
the
OBPIH-4770
branch
from
a9bd9dc
to
d003b6e
Compare
awalkowiak
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also found in the mean time some minor issues on PO list and changed some state names on invoiceList which were copied from PO list and not changed by mistake.