OBPIH-4750 create the page with all elements filters table for inbound movements #3503
Conversation
- add new button variant primary-outline - remove duplicate button variant classes
- add endpoint for getting shipment status codes - save shipment status codes in redux global state
- center tooltip on cell value and not value container - add default value to TableCell component
- Creat Header, Filter, Table and List component for StockMovements inbound - add shipment status description translations
drodzewicz
force-pushed
the
OBPIH-4750-create-the-page-with-all-elements-filters-table-for-inbound-movements
branch
from
3632297
to
9bd0c19
Compare
awalkowiak
deleted the
OBPIH-4750-create-the-page-with-all-elements-filters-table-for-inbound-movements
branch
| } | ||
| form.reset(initialValues); | ||
| }; | ||
|
|
There was a problem hiding this comment.
it wasn't necessary (comment below)
| searchFieldPlaceholder="Search by order number of description" | ||
| filterFields={filterFields} | ||
| defaultValues={{ | ||
| ...filterParams, |
There was a problem hiding this comment.
you could just make defaultValues as
destination: {
id: currentLocation.id,
value: currentLocation.id,
name: currentLocation.name,
label: currentLocation.name,
},
and you wouldn't have to do this onClear prop. Assigning destination to filterParams as default state disables you from assigning it again if the filterParams change, so I probably know, why you made this onClear, but if you had passed destination as defaultValues here, you wouldn't have had to do this onClear.
|
|
||
|
|
||
| useEffect(() => { | ||
| if (!isShipmentStatusesFetched) fetchStatuses(); |
There was a problem hiding this comment.
I would add !isShipmentStatusesFetched || shipmentStatuses.length === 0 in case somehow it fetched empty list and we would want to refetch it (low possibiltiy to happen)
| name: props.currentLocation.name, | ||
| label: props.currentLocation.name, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
As commented above - filterParams should stay {}, but defaultValues passed to FilterForm should be this.
| // If filterParams change, refetch the data with applied filters | ||
| useEffect(() => { | ||
| fireFetchData(); | ||
| if (!isShipmentStatusesFetched) fetchStatuses(); |
There was a problem hiding this comment.
as above, I would add additional || shipmentStatuses.length === 0 for safety.
| { | ||
| sort: state.sorted[0].id, | ||
| order: state.sorted[0].desc ? 'desc' : 'asc', | ||
| } : undefined; |
There was a problem hiding this comment.
I assume anyway backend sorts by something by default, but if not, add here sorting by date by default maybe?
| setTotalData(res.data.totalCount); | ||
| setTableData(res.data.data); | ||
| // Store currently used params for export case | ||
| setCurrentParams(params); |
There was a problem hiding this comment.
as discussed yesterday, maybe do one object-state, so you don't have to make multiple setStates where each of them re-renders component?
No description provided.