OBPIH-4751 Fix deleting Stock Movements endpoint #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
awalkowiak
commented
Sep 28, 2022
awalkowiak
commented
- plus fix filtering by dateCreated for inbounds
- plus fix OutboundStockMovementListItem toJson mapper
- plus fix filtering by dateCreated for inbounds - plus fix OutboundStockMovementListItem toJson mapper
jmiranda
reviewed
Sep 29, 2022
There was a problem hiding this comment.
Ugh. Seems like an arduous task for something that should be relatively simple. Should we just rely on StockMovementService to return it for all three cases. Or continue to use
stockMovementService.deleteStockMovement()
and hide the ugly details underneath.
I don't know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.