OBPIH-4868 menus for non admin users #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for them - add ability to specify minimumRequired role to render a section/subsection/menuItem - remove few product menu items for non-admin users - remove configuration button for non admin users -remove create stocklist menu item for non-admin users
kchelstowski
approved these changes
Oct 4, 2022
awalkowiak
reviewed
Oct 4, 2022
| def minRole = it.minimumRequiredRole | ||
| if (minRole && !userService.isUserInRole(user, minRole)) { | ||
| return | ||
| } | ||
| def roles = it.requiredRole | ||
| if (roles && !userService.hasAnyRoles(user, roles)) { |
There was a problem hiding this comment.
Is the requiredRole still used in the config?
There was a problem hiding this comment.
it is used only on invoicing sections, where user is required to have ROLE_INVOICE
invoicing {
enabled = true
requiredRole = [RoleType.ROLE_INVOICE]
label = "react.invoicing.label"
defaultLabel = "Invoicing"
subsections = [ ... ]
}
awalkowiak
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally I have fixed many warning that cluttered the console for Menu component proptypes