OBPIH-4897 add autoincremental product code assignment when create products through import

[drodzewicz]

No description provided.

[jmiranda]

I don't know if this is what we want to do. Can you provide justification for this? The validation exception has an Errors object that includes an detailed error message for each invalid data element. Displaying just the message associated with the validation exception give us a generic error message without those details.

[drodzewicz]

for some reason, that I wasn't able to figure out, assigning e.errors to command.errors didn't work.
It didn't display any error messages on .gsp page even thought error was was thrown.

I will try to do product.errors.reject("...") inseatd of throwing an exception, I was just following an example where few line below we have

 if (!product.save(flush: true)) {
    hrow new ValidationException("Could not save product '" + product.name + "'", product.errors)
}

[jmiranda]

Right, that is supposed to be the place where we detect whether product has errors and if so it throws the exception. We don't need to throw a validation exception everywhere. We just need to collect all the errors in the Errors object and throw the exception with that one Errors object.

[jmiranda]

for some reason, that I wasn't able to figure out, assigning e.errors to command.errors didn't work.
It didn't display any error messages on .gsp page even thought error was was thrown.

What gsp is that?

[drodzewicz]

it was importAsCsv.gsp
https://github.com/openboxes/openboxes/blob/develop/grails-app/views/product/importAsCsv.gsp#L18
even thought it has appropriate logic for checking if command has errors and siplay those errors but for some reason it didn't as if it lost those errors somewhere along the way

[jmiranda]

Ok, well make the suggested change(s) and if you still can't get it to work I can take a look.

[jmiranda]

Instead of throwing an exception here you should just add to the product's errors object.

if (product.productType?.id != defaultProductType?.id && !product.productType?.code && !product.productType?.productIdentifierFormat) {
    product.errors.reject("...")
}

The save below should fail due to the error and throw the exception. If for some reason it doesn't you can call validate on your own.

if (!product.validate() || !product.save(flush:true)) {

[drodzewicz]

Unfortunately doing product.errors.reject("...") and after that calling product.validate() clears out previously assigned errors. I wasn't able to find any useful information on this topic but I assume that by calling product.validate() it just resets product.errors and validates the object based on specified constrains in the class.

So instead I moved my validation logic into validateProducts(csv) (where it probably should have been in the first place) and everything seems to work well there.

[jmiranda]

I still see the exception being thrown here.

https://github.com/openboxes/openboxes/pull/3547/files#diff-c318547de40b750cb640136d100a6aee922f7aae15814cdc220741c3e33d4575R641

[jmiranda]

Oh nevermind. I see what you did. But just for clarification ... validate should not clear product.errors so we should try to figure out how to do this properly at some point.