OBPIH-4924 fix putaway list redirects #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
drodzewicz
commented
Oct 14, 2022
drodzewicz
commented
- hide order list link button on show putaway show page
- fix redirect after delete pending putaway
- disable product type filter on putaway list
grails-app/views/order/_actions.gsp
Outdated
| ${warehouse.message(code: 'order.list.label')} | ||
| </g:link> | ||
| </g:if> | ||
| <g:elseif test="${orderInstance?.orderType != PUTAWAY_ORDER}"> |
There was a problem hiding this comment.
what if orderType is equal to PUTAWAY_ORDER? I can't see where we handle this case?
There was a problem hiding this comment.
that was the point of not rendering this button for PUTAWAY_ORDER but I guess it is not too clear enough from the code.
So I guess I'll just make it a <g:else> and add checking for orderInstance?.orderType != PUTAWAY_ORDER to line 15
There was a problem hiding this comment.
ok, I see, it was hard to "read" from the code what it is about to do, but I get the point now
- hide order list link button on show putaway show page - fix redirect after delete pending putaway - disable product type filter on putaway list
drodzewicz
force-pushed
the
OBPIH-4924-redirects-from-putaways-to-order-list
branch
from
baf146f
to
10b66ce
Compare
kchelstowski
approved these changes
Oct 14, 2022
kchelstowski
deleted the
OBPIH-4924-redirects-from-putaways-to-order-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.