OBPIH-5005 Add option to trigger summary refresh for items and adjust… #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
approved these changes
Oct 26, 2022
| @@ -74,6 +82,8 @@ class OrderItem implements Serializable, Comparable<OrderItem> { | |||
| Date dateCreated | |||
| Date lastUpdated | |||
|
|
|||
| Boolean disableRefresh = Boolean.TRUE | |||
There was a problem hiding this comment.
We usually set this to be false by default? Are there too many cases where we want to disable it by default?
There was a problem hiding this comment.
Yeah, I think it is better to disable it for items and adjustments by default. Otherwise, every flush on related objects will trigger the afterUpdate for those and if there will be a lot of items, then a lot of duplicated triggers. So I think for now the answer is yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ments