OBPIH-5136 enable deletion of a stock request #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalkowiak
requested changes
Nov 16, 2022
| } | ||
| } | ||
|
|
||
| def list = { | ||
|
|
||
| def max = params.max ? params.max as int : 10 |
There was a problem hiding this comment.
This seems to be wrong that it's there. I think this is strictly related to the list redesign changes.
There was a problem hiding this comment.
yes that's why I drafted this PR
I believe that during reverting my commit (that I did locally) I did something wrong on the StockMovementController
everything is up to date now
drodzewicz
force-pushed
the
OBPIH-5136
branch
from
dc817b5
to
65e49da
Compare
| <span><i className="fa fa-remove pr-2" /><Translate id="react.default.button.deleteAll.label" defaultMessage="Delete all" /></span> | ||
| <span> | ||
| <i className="fa fa-remove pr-2" /> | ||
| <Translate id="dw" defaultMessage="Cancel Request" /> |
There was a problem hiding this comment.
is this dw intentional?
drodzewicz
force-pushed
the
OBPIH-5136
branch
from
65e49da
to
1f8b8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.