OBPIH-5138 HOTFIX: QOH on blur updating quantity requested to 0 over and over again #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchelstowski
changed the title
kchelstowski
changed the title
awalkowiak
requested changes
Nov 18, 2022
| valuesWithUpdatedQtyRequested.lineItems[rowIndex].quantityRequested = | ||
| values.lineItems[rowIndex].quantityAllowed - fieldValue >= 0 ? | ||
| values.lineItems[rowIndex].quantityAllowed - fieldValue : 0; | ||
| const lineItem = valuesWithUpdatedQtyRequested.lineItems[rowIndex]; |
There was a problem hiding this comment.
Actually, these could be moved to a separate method and passed like the updateRow.
awalkowiak
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was, that whenever we've gone from QOH, the quantityRequested (Needed Qty) was updated to 0 (if there was not any demand). I think the problem has not been seen before, because whenever we were adding a new line, we were not going from QOH from previous product to QOH of next product and we were always going from left to right.
The problem was happening both for keyboard and mouse, but when switching the cells by mouse, the quantity was not updating in the table until you added a new line (but when console.loging the values, they were 0).