OBPIH-5165 Adjust badge count total to count only selected fields that user can select #3643
Conversation
…t user can select
drodzewicz
requested review from
awalkowiak and
kchelstowski
and removed request for
awalkowiak
| // Ignore accounting for filter that is specified in "ignoreClearFilters" | ||
| if (ignoreClearFilters.includes(key)) return false; | ||
| // Ignore filter that is not specified in filterFields config | ||
| // and that is not a search field |
There was a problem hiding this comment.
what are examples of filters that are not specified in filterFields? Because I can't remind myself of such case?
There was a problem hiding this comment.
This was the case where the badge counter would count filters such as direction=INBOUND on inbound pages or for requests direction=OUTBOUND&sourceType=ELECTRONIC.
These filters are not specified in the filterFields
There was a problem hiding this comment.
Aren’t they added to the filterFields anyway when building defaultFilterValues?
In the place, where you are looking on query params and adding them to filterValues?
There was a problem hiding this comment.
The query params filters are added to filterValues but filterFields stays unchanged.
FilterFields is like a configuration object that specifies what filters/components to load and we are never changing it.
There was a problem hiding this comment.
Oh, I see, I was thinking about filterValues all the time. I didn’t mean you had done something wrong, but just wanted to know, what is going on there.
If it’s filterFields then I’m fine with it now
awalkowiak
deleted the
OBPIH-5165-adjust-badge-count-total-to-count-only-selected-fields-that-user-can-select
branch
No description provided.