OBPIH-5163 Users with Browser permissions can't see the PO list page #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalkowiak
reviewed
Nov 24, 2022
| @@ -1133,7 +1133,7 @@ openboxes.security.rbac.rules = [ | |||
| [controller: 'glAccount', actions: ['delete'], accessRules: [minimumRequiredRole: RoleType.ROLE_SUPERUSER]], | |||
| [controller: 'glAccountType', actions: ['delete'], accessRules: [minimumRequiredRole: RoleType.ROLE_SUPERUSER]], | |||
| [controller: 'preferenceType', actions: ['delete'], accessRules: [minimumRequiredRole: RoleType.ROLE_SUPERUSER]], | |||
| [controller: 'purchaseOrderApi', actions: ['*'], accessRules: [ minimumRequiredRole: RoleType.ROLE_ASSISTANT]], | |||
| [controller: 'purchaseOrderApi', actions: ['delete'], accessRules: [ minimumRequiredRole: RoleType.ROLE_ASSISTANT]], | |||
There was a problem hiding this comment.
Should rollback action also be available to everyone?
There was a problem hiding this comment.
Rollback depends on Approver role and we check it on the frontend side:
const rollbackHandler = (id) => {
if (!isUserApprover) {
Alert.error(translate(
'react.default.errors.noPermissions.label',
'You do not have permissions to perform this action',
));
return;
}
(....)
There was a problem hiding this comment.
But through API you can now do this having any kind of role. So it also should also be here if you need a supplementary role Approver.
awalkowiak
approved these changes
Nov 24, 2022
awalkowiak
pushed a commit
that referenced
this pull request
Nov 29, 2022
…3652) * OBPIH-5163 Users with Browser permissions can't see the PO list page * OBPIH-5163 Add rule for rollback action for purchase orders * OBPIH-5163 Fix supplementalRoles to be list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed with Katarzyna, that delete should be still only for >= Assistants