OBPIH-5076 Add missing translation labels on stock movement #3672
Conversation
There was a problem hiding this comment.
@jmiranda do we want to go with g:message -> warehouse:message change, or we're waiting with the g:message investigation?
I would prefer to wait on the investigation so we don't needlessly change this all around. |
drodzewicz
force-pushed
the
OBPIH-5076-elements-of-the-shipment-view-page-not-translatable-with-crowdin
branch
2 times, most recently
from
c79ef9d
to
dbef1e2
Compare
|
I have rolled back my changes where I changed |
grails-app/views/returns/show.gsp
Outdated
| @@ -130,7 +130,12 @@ | |||
| <g:message code="stockMovement.status.label"/> | |||
| </td> | |||
| <td class="value"> | |||
| <format:metadata obj="${stockMovement?.shipment?.status?:stockMovement?.statusCode}"/> | |||
| <g:if test="${stockMovement?.shipment?.status}"> | |||
There was a problem hiding this comment.
@drodzewicz Is there a reason behind this change into if-else? You could add the ?.code to the first part and have the same result:
<format:metadata obj="${stockMovement?.shipment?.status?.code ?: stockMovement?.statusCode}"/>
| @@ -166,7 +166,12 @@ | |||
| <warehouse:message code="stockMovement.status.label"/> | |||
| </td> | |||
| <td class="value"> | |||
| <format:metadata obj="${stockMovement?.shipment?.status?:stockMovement?.requisition?.status }"/> | |||
| <g:if test="${stockMovement?.shipment?.status}"> | |||
drodzewicz
force-pushed
the
OBPIH-5076-elements-of-the-shipment-view-page-not-translatable-with-crowdin
branch
from
dbef1e2
to
e421632
Compare
awalkowiak
deleted the
OBPIH-5076-elements-of-the-shipment-view-page-not-translatable-with-crowdin
branch
No description provided.