OBPIH-5090 adjust field length with field content in select fields of reusable filter component #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
filter input width is dependant on the width of the content that is displayed in the input or width of the placeholder I have also cherry-picked a commit from OBPIH-5171 from hotfix-2 because I figured that it might have an impact on the behavior of the filterSelect component |
drodzewicz
force-pushed
the
OBPIH-5090-adjust-field-length-with-field-content-in-select-fields-of-reusable-filter-component
branch
from
4a2c20a
to
a51a3ad
Compare
…the input filter input width is dependant on the width of the content that is displayed in the input or width of the placeholder
drodzewicz
force-pushed
the
OBPIH-5090-adjust-field-length-with-field-content-in-select-fields-of-reusable-filter-component
branch
from
a51a3ad
to
e33c5ff
Compare
kchelstowski
reviewed
Dec 6, 2022
| disabled={!allowEmptySubmit && _.every(values, value => !value)} | ||
| variant="primary" | ||
| type="submit" | ||
| type="button" |
There was a problem hiding this comment.
I'm just wondering why it has been changed? Isn't onSubmit unnecessary now?
What were the sideeffects that onClick={() => updateFilterParams(values)} handles and submit doesn't, if onSubmit we are also calling the same (updateFilterParams)?
awalkowiak
approved these changes
Dec 6, 2022
awalkowiak
deleted the
OBPIH-5090-adjust-field-length-with-field-content-in-select-fields-of-reusable-filter-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.