OBPIH-5091 Make selected options appear at the top of dropdown after … #3683
Conversation
…closing and opening the dropdown
src/js/utils/Select.jsx
Outdated
| @@ -129,6 +130,30 @@ class Select extends Component { | |||
| } | |||
| } | |||
|
|
|||
| sortOptionsByChecked(options, checkedValues) { | |||
| const groupedByChecked = | |||
| options?.length ? | |||
There was a problem hiding this comment.
I remember a while back I found a nice way for parting array based on a condition just like you have and used this logic.
let checked = [];
let unchecked = [];
options?.forEach((val) => {
if (checkedValues?.some(val => val.id === curr.id) {
checked.push(val)
} else {
unchecked.push(val)
}
})
This in my opinion feels shorter and more explicit/easier to read, but if you still would like to stick to reduce then I don;t have a problem maybe just change condition checking for options?.length from a ternary operator ? ... : ... to a simpler if statemenet becasue ternary operator makes the code a little too clutered
There was a problem hiding this comment.
as you probably know, I'm a fan of functional programming and immutable approach, so that's why I prefer the reduce approach instead of forEach function which is a void function.
If it doesn't bother you that much, I'd love to stay with the reduce version, as for if, I can agree and will change it :)
…closing and opening the dropdown