Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBPIH-5133 Return exact match on product search API #3693

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Conversation

jmiranda
Copy link
Member

@jmiranda jmiranda commented Dec 8, 2022

No description provided.

Copy link
Collaborator

@awalkowiak awalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was wondering if we would want to find an exact match with case insensitive option, but considering that codes don't have to have only capital letters, I think case-sensitive is a better approach.

@jmiranda jmiranda merged commit 6dc35c1 into develop Dec 9, 2022
@jmiranda jmiranda deleted the OBPIH-5133 branch December 9, 2022 14:51
@jmiranda
Copy link
Member Author

jmiranda commented Dec 9, 2022

@awalkowiak Sorry just saw this comment. I think that's a great point. In the case of a barcode scanner it won't matter since the barcode value should be exactly the same as the value in the database. If that's not the case, then that's a data issue.

But if someone is typing the value on their own then i think case insensitivity makes sense. We should mention that in the ticket, but let's let this breathe a little in QA / UAT and let Katarzyna and Kelsey decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants