Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBPIH-5236 Add front-end unit tests for Util components and functions #3718

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

alannadolny
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@awalkowiak awalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but I had one question

@@ -1,4 +1,5 @@
{
"parser": "@babel/eslint-parser",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required in the end?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I forgot to remove that

@awalkowiak awalkowiak merged commit 95a9a83 into develop Dec 19, 2022
@awalkowiak awalkowiak deleted the OBPIH-5236 branch December 19, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants