Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBPIH-5266 Create API architecture for React side and assign API urls to consts/json instead of using hardcoded api urls for PO list #3744

Merged
merged 5 commits into from
Jan 3, 2023

Conversation

alannadolny
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@kchelstowski kchelstowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really impressed by this approach. I'm glad we figured out such an idea. Can't wait to see it in more places

'Rollback of order status has been done successfully',
));
fireFetchData();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that you are not the author, but I believe there also should be spinner added. Would you mind adding it?

Copy link
Collaborator

@drodzewicz drodzewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jmiranda jmiranda merged commit 7025ef3 into develop Jan 3, 2023
@jmiranda jmiranda deleted the OBPIH-5266 branch January 3, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants