OBPIH-5216 Add missing translations to EXPIRING stock raport #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodzewicz
reviewed
Jan 3, 2023
| @@ -171,7 +171,7 @@ | |||
| ${quantityMap[inventoryItem]} | |||
| </td> | |||
| <td class="checkable center" > | |||
| ${inventoryItem?.product?.unitOfMeasure?:"EA" } | |||
| <g:message code="default.uom.${inventoryItem?.product?.unitOfMeasure?.toLowerCase()}.uppercase.label" default="EA"/> | |||
There was a problem hiding this comment.
I am not sure that this is how we want to translate unit of measure variables.
We still have yet to discuss the best approach for this on one of the upcoming tech huddles.
We also have an open ticket for UOM translations OBPIH-5187
There was a problem hiding this comment.
thanks for pointing that out, I haven't known about this ticket before. So I'm gonna revert this change for now, and it will be covered later.
There was a problem hiding this comment.
Thanks for catching that @drodzewicz. As I mentioned in a PR earlier today we should never have a label for uppercase vs lowercase. We can wrap these values with StringUtils.lowerCase() vs StringUtils.upperCase() or StringUtils.capitalize().
drodzewicz
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.