OBPIH-5177 update missing translations on transaction report #3759
Conversation
drodzewicz
force-pushed
the
OBPIH-5177-not-translatable-with-crowdin-in-transactions-report
branch
from
5ca0c25
to
86bd5f1
Compare
drodzewicz
requested review from
kchelstowski and
jmiranda
and removed request for
kchelstowski
| <th><g:message code="default.date.label" default="Date"/></th> | ||
| <th><g:message code="default.time.label" default="Time"/></th> | ||
| <th><g:message code="transaction.transactionType.label" default="Type"/></th> | ||
| <th><g:message code="report.transactionType.transactionCode.label" default="Transaction Code"/></th> |
There was a problem hiding this comment.
Let's include the missing code to message.properties instead of adding a brand new code.
transactionType.label=Transaction Type
transactionType.transactionCode.label=Transaction Code
There was a problem hiding this comment.
the transactionType.label is already an existing translation code, here I only added the default message
<th><g:message code="transaction.transactionType.label" default="Type"/></th>
| <th><g:message code="transaction.transactionType.label" default="Type"/></th> | ||
| <th><g:message code="report.transactionType.transactionCode.label" default="Transaction Code"/></th> | ||
| <th><g:message code="default.quantity.label" default="Quantity"/></th> | ||
| <th><g:message code="report.quantityBalance.label" default="Balance"/></th> |
There was a problem hiding this comment.
I prefer leaving this as default.balance.label
| @@ -112,7 +116,8 @@ | |||
| name="tags" | |||
| id="tags" | |||
| value="${params?.tags}" | |||
| multiple="true" | |||
| data-placeholder="${g.message(code: "default.selectSomeOptions.label", default: "Select some option")}" | |||
There was a problem hiding this comment.
Change this to
default.selectOptions.label=Select Options
I think the default "Select some option(s)" (or whatever) is provided by the chosen plugin and I'm not a fan.
| <g:selectCategory | ||
| id="category" | ||
| class="chzn-select-deselect filter" | ||
| data-placeholder="${g.message(code: 'product.selectACategory.label', default: 'Select a category')}" |
There was a problem hiding this comment.
In cases where the label / message has an article (a, the, etc) you can exclude the article in the code (even if you keep it in the translated value).
product.selectCategory.label=Select a category
also for this one the namespace should be category.
category.selectCategory.label=Select a category
86bd5f1
to
a49835f
Compare
|
@drodzewicz this one has conflicts |
|
@drodzewicz @kchelstowski As we discussed last week, once the PR is ready for review just remove all labels i.e. don't add |
drodzewicz
force-pushed
the
OBPIH-5177-not-translatable-with-crowdin-in-transactions-report
branch
from
a49835f
to
9ae6edf
Compare
drodzewicz
force-pushed
the
OBPIH-5177-not-translatable-with-crowdin-in-transactions-report
branch
from
9ae6edf
to
c4b0e9e
Compare
jmiranda
deleted the
OBPIH-5177-not-translatable-with-crowdin-in-transactions-report
branch
No description provided.