OBPIH-5207 Fix crowdin translations on Dashboard #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
drodzewicz
commented
Jan 10, 2023
drodzewicz
commented
- Add missing translations for Dashboards sidebar items
- Add missing translation For labels on Archive indicators, save config etc.
- Fix truncated label causing crowding not to translate it properly
- Modify indicator filter component option label rendering to instead accept arguments in the label for more control on the order of words
kchelstowski
requested changes
Jan 10, 2023
src/css/main.scss
Outdated
| .text-align-left { | ||
| text-align: left; | ||
| } | ||
|
|
There was a problem hiding this comment.
don't we have text-left in bootstrap?
There was a problem hiding this comment.
you are right, thanks
fixed it
drodzewicz
force-pushed
the
OBPIH-5207-not-translatable-with-crowdin-in-dashboard
branch
from
8e34e1f
to
3f43e17
Compare
- Add missing translations for Dashboards sidebar items - Add missing translation For labels on Archive indicators, save config etc. - Fix truncated label causing crowding not to translate it properly - Modify indicator filter component option label rendering to instead accept arguments in the label for more control on the order of words
kchelstowski
approved these changes
Jan 10, 2023
jmiranda
deleted the
OBPIH-5207-not-translatable-with-crowdin-in-dashboard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.