OBPIH-5329 Improve performance after deleting location #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue due to the fact, that 'get' expects one result but these criteria might return more objects.
jmiranda
reviewed
Jan 21, 2023
| if (zone) { | ||
| existingLocation.zone = null | ||
| zone.removeFromLocations(existingLocation) | ||
| zone.save(flush: true) |
There was a problem hiding this comment.
This shouldn't be necessary since there's no association between zone and internal locations so this is basically a no-op. I assume this is in response to an issue you had (something like "deleted object would be re-saved"). In the future, can you add any issues you encounter to the ticket a) so there's an audit trail of the issue and b) so we can discuss it.
| } | ||
| } | ||
| // Find by name with like, but value more the exact match | ||
| locationType = LocationType.findByNameOrNameIlike(params.locationType, params.locationType + "%") |
There was a problem hiding this comment.
Could you explain why this was necessary?
| @@ -34,7 +34,8 @@ class RefreshProductAvailabilityEvent extends ApplicationEvent { | |||
| this.locationId = source?.isInternalLocation() ? source?.parentLocation?.id : source?.id | |||
| this.productIds = [] | |||
| this.forceRefresh = forceRefresh | |||
| this.disableRefresh = disableRefresh | |||
| // Avoid refreshing PA for all location, when there is no locationId | |||
| this.disableRefresh = this.locationId ? disableRefresh : Boolean.TRUE | |||
There was a problem hiding this comment.
This should probably be the only commit for this ticket. The other issues should have separate bug tickets that include the stacktrace and/or steps to reproduce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus fixed deleting bin location with zone
plus fixed finding location type by name during import